Skip to content

made printing to console optional when set_time() fails. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2020
Merged

made printing to console optional when set_time() fails. #14

merged 2 commits into from
Dec 9, 2020

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Dec 9, 2020

Uses a new optional parameter ("debug") when creating an instance of the NTP class

Fixes #13

…ptional parameter ("debug") when creating an instance of the NTP class
@kattni kattni requested a review from a team December 9, 2020 23:20
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you for submitting this fix. Please see the suggestion below.

Co-authored-by: Kattni <kattni@adafruit.com>
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@kattni kattni merged commit 617bf6d into adafruit:master Dec 9, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make output of set_time() failures to console only show when needed
2 participants